Rectify nearly all type errors revealed by mypy on current repo
#3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3267 +/- ##
========================================
Coverage 93.17% 93.18%
========================================
Files 66 66
Lines 14339 14342 +3
========================================
+ Hits 13361 13365 +4
+ Misses 978 977 -1 ☔ View full report in Codecov by Sentry. |
added 2 commits
October 1, 2024 02:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves nearly all of the errors produced by
mypyand passes the same number of tests as before, reducing the number of type errors from 43 to 7 (6 of which are in the vendored code fromsix). This is laying the groundwork for a more extensive effort at annotating this code.Before:
After:
Command line: